agavra commented on code in PR #9806:
URL: https://github.com/apache/pinot/pull/9806#discussion_r1024305534
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -131,6 +137,12 @@ protected void compareRowEquals(List<Object[]> resultRows,
List<Object[]> expect
return ((String) l).compareTo((String) r);
} else if (l instanceof Boolean) {
return ((Boolean) l).compareTo((Boolean) r);
+ } else if (l instanceof BigDecimal) {
+ if (r instanceof BigDecimal) {
+ return ((BigDecimal) l).compareTo((BigDecimal) r);
+ } else {
+ return ((BigDecimal) l).compareTo(new BigDecimal((String) r));
Review Comment:
JSON represents them as strings - so in the cases of specified `outputs` we
need to be able to compare them to strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
