61yao commented on code in PR #9806:
URL: https://github.com/apache/pinot/pull/9806#discussion_r1024407637
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java:
##########
@@ -70,6 +70,8 @@ private RelDataType toRelDataType(FieldSpec fieldSpec) {
return createSqlType(SqlTypeName.VARCHAR);
case BYTES:
return createSqlType(SqlTypeName.VARBINARY);
+ case BIG_DECIMAL:
Review Comment:
I feel adding a new data type needs a lot more thorough testing. Say we make
sure func calls work on this, filter/transform work on this etc.
It is better to say we don't support this type instead of we support this
sometimes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
