agavra commented on code in PR #9806:
URL: https://github.com/apache/pinot/pull/9806#discussion_r1024507294


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java:
##########
@@ -70,6 +70,8 @@ private RelDataType toRelDataType(FieldSpec fieldSpec) {
         return createSqlType(SqlTypeName.VARCHAR);
       case BYTES:
         return createSqlType(SqlTypeName.VARBINARY);
+      case BIG_DECIMAL:

Review Comment:
   also I think Rong was referring to `FieldSpec.java` where I added:
   ```
               case BIG_DECIMAL:
                  return DEFAULT_DIMENSION_NULL_VALUE_OF_BIG_DECIMAL;
   ```
   this change that you're commenting on was the TypeFactory that maps Calcite 
types to Pinot types.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to