siddharthteotia commented on code in PR #9909:
URL: https://github.com/apache/pinot/pull/9909#discussion_r1044763620
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/FilterOperator.java:
##########
@@ -92,7 +95,7 @@ private TransferableBlock transform(TransferableBlock block)
List<Object[]> resultRows = new ArrayList<>();
List<Object[]> container = block.getContainer();
for (Object[] row : container) {
- if (_filterOperand.apply(row)) {
+ if ((Boolean) FunctionInvokeUtils.convert(_filterOperand.apply(row),
DataSchema.ColumnDataType.BOOLEAN)) {
Review Comment:
Similar to current engine, should we consider splitting `FilterOperator` of
multi-stage into FilterOperator and a separate filter operation for expression
(non identifier) based filters ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
