siddharthteotia commented on code in PR #9909:
URL: https://github.com/apache/pinot/pull/9909#discussion_r1044854247
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FilterOperand.java:
##########
@@ -243,28 +103,32 @@ public Predicate(List<RexExpression> functionOperands,
DataSchema dataSchema) {
* <li>if we can't resolve a common data type, exception occurs.</li>
* </ul>
*
- * @param lhsType left-hand-side type
- * @param rhsType right-hand-side type
- * @return best common conversion data type.
- * @see DataSchema.ColumnDataType#isSuperTypeOf(DataSchema.ColumnDataType)
+ *
*/
- private static DataSchema.ColumnDataType
resolveResultType(DataSchema.ColumnDataType lhsType,
- DataSchema.ColumnDataType rhsType) {
+ public Predicate(List<RexExpression> functionOperands, DataSchema
inputDataSchema) {
+ Preconditions.checkState(functionOperands.size() == 2,
+ "Expected 2 function ops for Predicate but got:" +
functionOperands.size());
Review Comment:
include the operands as well in the exception message ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
