xiangfu0 commented on code in PR #9977:
URL: https://github.com/apache/pinot/pull/9977#discussion_r1046726884
##########
pinot-tools/src/main/resources/examples/stream/airlineStats/airlineStats_realtime_table_config.json:
##########
@@ -25,8 +25,7 @@
"stream.kafka.zk.broker.url": "localhost:2191/kafka",
"stream.kafka.broker.list": "localhost:19092",
"realtime.segment.flush.threshold.time": "3600000",
- "realtime.segment.flush.threshold.size": "50000",
- "stream.kafka.consumer.prop.auto.offset.reset": "smallest"
+ "realtime.segment.flush.threshold.size": "50000"
Review Comment:
why remove this?
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -255,6 +255,11 @@ public void deleteSegmentFile() {
private StreamPartitionMsgOffset _finalOffset; // Used when we want to catch
up to this one
private volatile boolean _shouldStop = false;
+ /** This variable will be set by the configured {@literal
IngestionBasedConsumptionStatusChecker} when the segment is
+ * caughtup.
+ */
+ private volatile boolean _caughtUpWithUpstream = false;
Review Comment:
This will be true once the server is caughtup, how do you handle the
scenario that a sudden traffic burst or consumer pause/resume?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
