navina commented on code in PR #9977:
URL: https://github.com/apache/pinot/pull/9977#discussion_r1047579926
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -255,6 +255,11 @@ public void deleteSegmentFile() {
private StreamPartitionMsgOffset _finalOffset; // Used when we want to catch
up to this one
private volatile boolean _shouldStop = false;
+ /** This variable will be set by the configured {@literal
IngestionBasedConsumptionStatusChecker} when the segment is
+ * caughtup.
+ */
+ private volatile boolean _caughtUpWithUpstream = false;
Review Comment:
I just realized that pause/resume works at a table level, which means it is
for all stream partitions. Whereas, this metric is created at a
partition-level, rather than a stream level. So, I don't think we can even
detect pause/resume in the table data manager. This will require yet another
indicator on the controller side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
