61yao commented on code in PR #9968:
URL: https://github.com/apache/pinot/pull/9968#discussion_r1048196112
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/OperatorUtils.java:
##########
@@ -40,6 +45,8 @@ public class OperatorUtils {
OPERATOR_TOKEN_MAPPING.put("*", "times");
OPERATOR_TOKEN_MAPPING.put("/", "divide");
OPERATOR_TOKEN_MAPPING.put("||", "concat");
+ SUPPORTED_EXCHANGE_TYPE.add(RelDistribution.Type.RANDOM_DISTRIBUTED);
+ SUPPORTED_EXCHANGE_TYPE.add(RelDistribution.Type.HASH_DISTRIBUTED);
Review Comment:
because today the only use for BROADCAST EXCHANGE is when join key is empty
in PinotJoinExchangeNodeInsertRule.
When this happens, we make left join table local and broadcast right table
to every server.
1) right table broadcast is a waste under this situation because we only
need it for 1 server.
2) We have a bug for singleton broadcast. We should solve the local exchange
optimization in a different way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
