61yao commented on PR #9968: URL: https://github.com/apache/pinot/pull/9968#issuecomment-1350701320
> IIRC, singleton exchange is local to local exchange ? > > I think we had already made changes to share the memory / result efficiently for a local exchange without actually going thought the local RPC call stack. > > Do we still generate mailbox sender and receiver operator for local exchange then ? I think today the singleton exchange abstraction is broken. singleton should really mean it only has one server to choose from. it could be local or over the network. Local to local exchange should happen when sender and receiver are the same, this can be done in a different way. We did make the optimization for local exchange. 1) it has abstraction issue and a timeout bug 2) this local exchange can still happen if we put sender and receiver the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
