klsince commented on code in PR #10158:
URL: https://github.com/apache/pinot/pull/10158#discussion_r1082973891
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/store/SegmentDirectory.java:
##########
@@ -181,24 +180,28 @@ public abstract PinotDataBuffer getIndexFor(String
column, ColumnIndexType type)
public abstract boolean hasIndexFor(String column, ColumnIndexType type);
- public SegmentDirectory toSegmentDirectory() {
- return SegmentDirectory.this;
- }
-
- public abstract String toString();
-
- public PinotDataBuffer getStarTreeIndex()
Review Comment:
fyi, `getStarTreeIndex ` and `getStarTreeIndexMap` were added very recenlty
by https://github.com/apache/pinot/pull/9828 but they didn't abstract the
access to ST index very cleanly. This PR improves on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
