klsince commented on code in PR #10158:
URL: https://github.com/apache/pinot/pull/10158#discussion_r1083147691
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/SegmentLocalFSDirectory.java:
##########
@@ -248,25 +250,26 @@ protected void load()
private synchronized void loadData()
throws IOException {
- if (_columnIndexDirectory != null) {
- return;
+ if (_columnIndexDirectory == null) {
Review Comment:
The new changes continue to ensure _columnIndexDirectory (and
_starTreeIndexReader) is loaded once. I separate their handling because the
SegmentDirectory.Writer closes and sets _columnIndexDirectory to null, but
Writer doesn't need to close and set _starTreeIndexReader to null, as it is for
readonly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
