siddharthteotia commented on code in PR #10169:
URL: https://github.com/apache/pinot/pull/10169#discussion_r1084755879
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java:
##########
@@ -111,6 +116,10 @@ private BaseResultsBlock getCombinedResults() {
try {
prefetchAll();
return _combineOperator.nextBlock();
+ } catch (EarlyTerminationException e) {
+ Exception killedErrorMsg =
Tracing.getThreadAccountant().getErrorStatus();
+ return new ExceptionResultsBlock(new QueryCancelledException(
+ "Cancelled while combining results" + (killedErrorMsg == null ?
StringUtils.EMPTY : " " + killedErrorMsg)));
Review Comment:
So one difference between this and the existing code is that this is not
including the original exception which could have been `InterruptedException`
or `EarlyTerminationExcetption`.
The original code was including that inside `QueryCancelledException`,
whereas here we have folded both into `EarlyTerminationExcetption`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
