Jackie-Jiang commented on code in PR #10169:
URL: https://github.com/apache/pinot/pull/10169#discussion_r1085975802
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java:
##########
@@ -111,6 +116,10 @@ private BaseResultsBlock getCombinedResults() {
try {
prefetchAll();
return _combineOperator.nextBlock();
+ } catch (EarlyTerminationException e) {
+ Exception killedErrorMsg =
Tracing.getThreadAccountant().getErrorStatus();
+ return new ExceptionResultsBlock(new QueryCancelledException(
+ "Cancelled while combining results" + (killedErrorMsg == null ?
StringUtils.EMPTY : " " + killedErrorMsg)));
Review Comment:
In the original code, we expect all the exceptions being handled within the
combine operator, which might not always be the case because interrupt might be
handled in `nextBlock()` call instead of the `getNextBlock()`, which will throw
`EarlyTerminationException`. In order to handle all of them, we should throw
`EarlyTerminationException` out and let the `InstanceResponseOperator` to
handle it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
