walterddr commented on code in PR #10169:
URL: https://github.com/apache/pinot/pull/10169#discussion_r1086022612
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseSingleBlockCombineOperator.java:
##########
@@ -111,13 +105,11 @@ protected void processSegments() {
((AcquireReleaseColumnsSegmentOperator) operator).release();
}
}
-
+ _blockingQueue.offer(resultsBlock);
+ // When query is satisfied, skip processing the remaining segments
if (_resultsBlockMerger.isQuerySatisfied(resultsBlock)) {
- // Query is satisfied, skip processing the remaining segments
- _blockingQueue.offer(resultsBlock);
+ _nextOperatorId.set(_numOperators);
Review Comment:
sounds good. i think the ResultBlockerMerger javadoc also stated that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
