siddharthteotia commented on code in PR #10171:
URL: https://github.com/apache/pinot/pull/10171#discussion_r1092359480
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -733,7 +748,7 @@ public static class Accounting {
public static final String CONFIG_OF_ALARMING_LEVEL_HEAP_USAGE_RATIO =
"accounting.oom.alarming.usage.ratio";
public static final float DEFAULT_ALARMING_LEVEL_HEAP_USAGE_RATIO = 0.75f;
- public static final String CONFIG_OF_HEAP_USAGE_PUBLISH_PERIOD =
"accounting.heap.usage.publish.period";
+ public static final String CONFIG_OF_HEAP_USAGE_PUBLISHING_PERIOD =
"accounting.heap.usage.publishing.period";
Review Comment:
just to clarify - we publish every 5 secs ?
you might want to include the unit (millis or whatever) as a suffix in the
config name key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
