jasperjiaguo commented on code in PR #10171:
URL: https://github.com/apache/pinot/pull/10171#discussion_r1092693262
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/AggregationDataTableReducer.java:
##########
@@ -102,6 +103,7 @@ private void reduceWithIntermediateResult(DataSchema
dataSchema, Collection<Data
intermediateResults[i] =
_aggregationFunctions[i].merge(mergedIntermediateResult,
intermediateResultToMerge);
}
Review Comment:
Yes. Although generally there shouldn't be that many of aggregation
functions, this should change to
LoopUtils.sampleAndCheckInterruptionPeriodically for generality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
