walterddr commented on code in PR #10214:
URL: https://github.com/apache/pinot/pull/10214#discussion_r1094884494
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##########
@@ -76,6 +80,8 @@ public
LeafStageTransferableBlockOperator(List<InstanceResponseBlock> baseResult
_errorBlock = baseResultBlock.stream().filter(e ->
!e.getExceptions().isEmpty()).findFirst().orElse(null);
_currentIndex = 0;
_operatorStats = new OperatorStats(requestId, stageId, EXPLAIN_NAME);
+ _metadata = OperatorUtils.aggregateMetadata(
+
_baseResultBlock.stream().map(InstanceResponseBlock::getResponseMetadata).collect(Collectors.toList()));
Review Comment:
operatorStats and metadata looks duplicate. let's try to come up with a more
unified definition (but no need to do it in this PR)
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -91,6 +91,7 @@ private MailboxContent toMailboxContent(DataBlock dataBlock) {
Mailbox.MailboxContent.Builder builder =
Mailbox.MailboxContent.newBuilder().setMailboxId(_mailboxId)
.setPayload(ByteString.copyFrom(dataBlock.toBytes()));
if (dataBlock instanceof MetadataBlock) {
+ builder.putAllMetadata(((MetadataBlock) dataBlock).getStats());
Review Comment:
why do we need to put stats into the mailboxContent? i thought they are
encoded inside the MetadataBlock already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
