walterddr commented on code in PR #10214:
URL: https://github.com/apache/pinot/pull/10214#discussion_r1106673215
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java:
##########
@@ -50,6 +64,17 @@ public TransferableBlock nextBlock() {
// TODO: move this to centralized reporting in broker
if (nextBlock.isEndOfStreamBlock()) {
LOGGER.info("Recorded operator stats: " + _operatorStats);
+ if (nextBlock.isSuccessfulEndOfStreamBlock()) {
+ for (MultiStageOperator op : getChildOperators()) {
+ _operatorStatsMap.putAll(op.getOperatorStatsMap());
+ }
+
+ if (!_operatorStats.getExecutionStats().isEmpty()) {
+ _operatorStatsMap.put(toExplainString() + "_" + _requestId + "_" +
_stageId, _operatorStats);
Review Comment:
here we should include explainName, stageId, requestId, and the serverId so
that upstream operators putAll will not overwrite one server's metadata on top
of another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
