Jackie-Jiang commented on code in PR #10260:
URL: https://github.com/apache/pinot/pull/10260#discussion_r1103353591
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/fwd/NoOpForwardIndexCreator.java:
##########
@@ -19,12 +19,13 @@
package org.apache.pinot.segment.local.segment.creator.impl.fwd;
import java.io.IOException;
+import java.math.BigDecimal;
import org.apache.pinot.segment.spi.index.creator.ForwardIndexCreator;
import org.apache.pinot.spi.data.FieldSpec;
/**
- * Forward index creator for dictionary-encoded single and multi-value columns
with forward index disabled.
+ * Forward index creator for dictionary-encoded and raw single and multi-value
columns with forward index disabled.
* This is a no-op.
*/
public class NoOpForwardIndexCreator implements ForwardIndexCreator {
Review Comment:
Suggest getting rid of this class and handle disabled forward index
explicitly instead of still dumping the values into the no-op creator for both
readability and performance concern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
