somandal commented on PR #10260: URL: https://github.com/apache/pinot/pull/10260#issuecomment-1426488746
> I feel we are over-complicating this problem. When inverted index does not exist, disabling forward index means only allowing using the index for the column (text, FST). No scan is allowed for the column, and there is no way to recover the column values or create other indexes. On the forward index handler side we can simply remove the forward index without worrying about creating other indexes. Yes I agree, for inverted index there isn't much to do and this PR doesn't do any special handling for it except relaxing the constraint. The main complexity here comes from handling changes to the dictionary. We have a scenario where the dictionary can be disabled for a forward index disabled column. For such scenarios we don't handle anything on reload today. Are you saying that even for toggling whether the dictionary is enabled or disabled we should just treat reload as a no-op rather than throwing error? What about indexes like the range index that need to be modified when the column has the dictionary enabled or disabled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
