Jackie-Jiang commented on code in PR #10268:
URL: https://github.com/apache/pinot/pull/10268#discussion_r1105095502


##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java:
##########
@@ -186,4 +186,11 @@ public void testCaseWithIsNotDistinctFrom()
     query = "SELECT description FROM " + getTableName() + " where description 
IS NOT DISTINCT FROM description";
     testQuery(query);
   }
+
+  @Test
+  public void testTotalCountUsingCountLiteral()
+          throws Exception {
+    String query = "SELECT COUNT(1) FROM " + getTableName();

Review Comment:
   I think you need to put `SET enableNullHandling = true;` to verify the 
desired behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to