61yao commented on code in PR #10268:
URL: https://github.com/apache/pinot/pull/10268#discussion_r1106579512
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java:
##########
@@ -50,7 +50,11 @@ public CountAggregationFunction(ExpressionContext
expression) {
public CountAggregationFunction(ExpressionContext expression, boolean
nullHandlingEnabled) {
super(expression);
// Consider null values only when null handling is enabled and function is
not COUNT(*)
- _nullHandlingEnabled = nullHandlingEnabled &&
!expression.getIdentifier().equals("*");
+ // Note COUNT on any literal gives same result as COUNT(*)
+ // So allow for identifiers that are not * and functions, disable for
literals and *
+ _nullHandlingEnabled = nullHandlingEnabled
+ && ((expression.getType() == ExpressionContext.Type.IDENTIFIER &&
!expression.getIdentifier().equals("*"))
+ || (expression.getType() == ExpressionContext.Type.FUNCTION));
Review Comment:
What's the motivation of adding function to enable null count?
The behavior should be :
When nullHandling is enabled
count() should ignore all nulls exception it is count(*)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
