andiem-bq commented on code in PR #10268:
URL: https://github.com/apache/pinot/pull/10268#discussion_r1107414022
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java:
##########
@@ -50,7 +50,11 @@ public CountAggregationFunction(ExpressionContext
expression) {
public CountAggregationFunction(ExpressionContext expression, boolean
nullHandlingEnabled) {
super(expression);
// Consider null values only when null handling is enabled and function is
not COUNT(*)
- _nullHandlingEnabled = nullHandlingEnabled &&
!expression.getIdentifier().equals("*");
+ // Note COUNT on any literal gives same result as COUNT(*)
+ // So allow for identifiers that are not * and functions, disable for
literals and *
+ _nullHandlingEnabled = nullHandlingEnabled
+ && ((expression.getType() == ExpressionContext.Type.IDENTIFIER &&
!expression.getIdentifier().equals("*"))
+ || (expression.getType() == ExpressionContext.Type.FUNCTION));
Review Comment:
Previous behaviour was count ignore all nulls for all expressions that are
identifiers that are not * . Expressions that are not identifiers (literals or
functions) result in exception because of the old check.
New behaviour is ignore all nulls for all expressions that are not count ( *
) or count(any literal). count( * ) and count(literal) both return rows. It
misses count(null) case tho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
