gortiz commented on PR #10361: URL: https://github.com/apache/pinot/pull/10361#issuecomment-1453122795
> we dont have a single concrete impl of the visitors in this PR so this PR is merely just a interface addition? Yes, just the interface in this PR. > do we have a concrete usage of this in a follow up PR? I'm working on a proprietary extension and I found this pattern would help me in the implementation. I didn't dedicate time trying to look for possible usages in Apache Pinot, but I'm sure we can use these interfaces in code we already wrote. I'm using them to be able to access the `matchingValue` attribute in a safe way without having to create a new method on the class to export it and without doing boxing (although I need to create a new Visitor, so the performance change shouldn't be significant). Alternatively we could just add a `getMatchingValue` (and similar to IN, NEQ and NIN). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
