walterddr commented on code in PR #10364:
URL: https://github.com/apache/pinot/pull/10364#discussion_r1125910207
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ExecutionStatsAggregator.java:
##########
@@ -89,7 +90,7 @@ public void aggregate(ServerRoutingInstance routingInstance,
DataTable dataTable
public synchronized void aggregate(@Nullable ServerRoutingInstance
routingInstance, Map<String, String> metadata,
Map<Integer, String> exceptions) {
// Reduce on trace info.
- if (_enableTrace) {
+ if (_enableTrace &&
metadata.containsKey(DataTable.MetadataKey.TRACE_INFO.getName())) {
Review Comment:
i see. we should clean this up later. it is not easy to track the code when
we have multiple way to determine the same config.
either we
1. dont set _enableTrace as member variable and always deduce from metadata
2. make _enableTrace correct without needing to look at metadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
