61yao commented on code in PR #10380:
URL: https://github.com/apache/pinot/pull/10380#discussion_r1129938791
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CoalesceTransformFunction.java:
##########
@@ -80,6 +80,36 @@ private static RoaringBitmap[]
getNullBitMaps(ProjectionBlock projectionBlock,
return roaringBitmaps;
}
+ /**
+ * Get compatible data type of left and right.
+ *
+ * When left or right is numerical, we check both data types are numerical
and widen the type.
+ * Otherwise, left and right have to be the same type.
+ * @param left data type
+ * @param right data type
+ * @return compatible data type.
+ */
+ private static DataType getCompatibleType(DataType left, DataType right) {
+ if (left.isNumeric()) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
