gortiz commented on code in PR #10380:
URL: https://github.com/apache/pinot/pull/10380#discussion_r1143231170
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/ExpressionContext.java:
##########
@@ -65,15 +65,6 @@ private ExpressionContext(Type type, String identifier,
FunctionContext function
_literal = literal;
}
- // TODO: Refactor all of the usage for getLiteralString.
- @Deprecated
- public String getLiteralString() {
Review Comment:
nit: In order to reduce the number of changes... why not just change this
code to call `_literal.getStringValue()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
