ankitsultana commented on code in PR #10408:
URL: https://github.com/apache/pinot/pull/10408#discussion_r1134494658
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/stage/MailboxReceiveNode.java:
##########
@@ -43,11 +57,25 @@ public MailboxReceiveNode(int stageId) {
public MailboxReceiveNode(int stageId, DataSchema dataSchema, int
senderStageId,
RelDistribution.Type exchangeType, @Nullable KeySelector<Object[],
Object[]> partitionKeySelector,
+ @Nullable List<RelFieldCollation> fieldCollations, boolean
isInputSorted, boolean sortOnReceiver,
Review Comment:
There's a related PR by @KKcorps where we are switching to a operator
context instead of individual args which may help simplify this.
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/stage/MailboxReceiveNode.java:
##########
@@ -43,11 +57,25 @@ public MailboxReceiveNode(int stageId) {
public MailboxReceiveNode(int stageId, DataSchema dataSchema, int
senderStageId,
RelDistribution.Type exchangeType, @Nullable KeySelector<Object[],
Object[]> partitionKeySelector,
+ @Nullable List<RelFieldCollation> fieldCollations, boolean
isInputSorted, boolean sortOnReceiver,
Review Comment:
There's a related PR by @KKcorps where we are switching to a operator
context instead of individual args which may help simplify this.
https://github.com/apache/pinot/pull/10413/files#diff-7ccb4a6b83288d4c1e1547c71a602c36dfbc90a8a283e9835c6d867cc2eeb2f3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
