somandal commented on code in PR #10408:
URL: https://github.com/apache/pinot/pull/10408#discussion_r1136541524
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -115,6 +125,11 @@ public
MailboxSendOperator(MailboxService<TransferableBlock> mailboxService,
_exchange = blockExchangeFactory.build(mailboxService, receivingMailboxes,
exchangeType, keySelector, splitter,
deadlineMs);
+ _collationKeys = collationKeys;
+ _collationDirections = collationDirections;
+ _sortOnSender = sortOnSender;
+ Preconditions.checkState(!sortOnSender, "Sort on send is not yet
implemented!");
Review Comment:
done
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -213,7 +213,7 @@ private void runLeafStage(DistributedStagePlan
distributedStagePlan, Map<String,
mailboxSendOperator = new MailboxSendOperator(_mailboxService,
new LeafStageTransferableBlockOperator(serverQueryResults,
sendNode.getDataSchema(), requestId,
sendNode.getStageId(), _rootServer),
receivingStageMetadata.getServerInstances(),
- sendNode.getExchangeType(), sendNode.getPartitionKeySelector(),
_rootServer, requestId,
+ sendNode.getExchangeType(), sendNode.getPartitionKeySelector(),
null, null, false, _rootServer, requestId,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
