Jackie-Jiang commented on code in PR #10411:
URL: https://github.com/apache/pinot/pull/10411#discussion_r1134495502
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -526,6 +538,9 @@ private File downloadSegmentFromDeepStore(String
segmentName, SegmentZKMetadata
} else {
try {
File tarFile = downloadAndDecrypt(segmentName, zkMetadata,
tempRootDir);
+ if (_isRetrySegmentDownloadUntarFailure) {
Review Comment:
Here we want to retry on download + untar together. Why not putting the
retry logic over the `downloadSegmentFromDeepStore()`?
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManagerParams.java:
##########
@@ -56,6 +76,38 @@ public void
setStreamSegmentDownloadUntarRateLimitBytesPerSec(long streamSegment
_streamSegmentDownloadUntarRateLimitBytesPerSec =
streamSegmentDownloadUntarRateLimitBytesPerSec;
}
+ public boolean isRetrySegmentDownloadUntarFailure() {
+ return _isRetrySegmentDownloadUntarFailure;
+ }
+
+ public void setRetrySegmentDownloadUntarFailure(boolean
retrySegmentDownloadUntarFailure) {
+ _isRetrySegmentDownloadUntarFailure = retrySegmentDownloadUntarFailure;
+ }
+
+ public int getRetryCount() {
Review Comment:
We need to rename these config keys to be specific for the segment download
untar retry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
