Jackie-Jiang commented on code in PR #10411:
URL: https://github.com/apache/pinot/pull/10411#discussion_r1137826666
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -526,6 +538,9 @@ private File downloadSegmentFromDeepStore(String
segmentName, SegmentZKMetadata
} else {
try {
File tarFile = downloadAndDecrypt(segmentName, zkMetadata,
tempRootDir);
+ if (_isRetrySegmentDownloadUntarFailure) {
Review Comment:
The same retry logic also exists in `downloadAndDecrypt()`. I feel the clean
fix should be change the `downloadAndDecrypt()` to `downloadAndDecryptUntar()`
which also untar the segment similar to
`downloadAndStreamUntarWithRateLimit()`. We already have the configurable
retries within the `SegmentFetcher`, and IMO we don't want another set of
configs to control the retry for untar.
cc @jasperjiaguo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
