walterddr commented on code in PR #10413:
URL: https://github.com/apache/pinot/pull/10413#discussion_r1136500528
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -277,26 +276,22 @@ public Object merge(Object agg, Object value) {
private static class AggregateAccumulator extends
AggregationUtils.Accumulator {
private static final Map<String, Function<DataSchema.ColumnDataType,
AggregationUtils.Merger>> AGG_MERGERS =
ImmutableMap.<String, Function<DataSchema.ColumnDataType,
AggregationUtils.Merger>>builder()
- .putAll(AggregationUtils.Accumulator.MERGERS)
- .put("FOURTHMOMENT",
+ .putAll(AggregationUtils.Accumulator.MERGERS).put("FOURTHMOMENT",
cdt -> cdt == DataSchema.ColumnDataType.OBJECT ? new
MergeFourthMomentObject()
- : new MergeFourthMomentNumeric())
- .put("$FOURTHMOMENT",
+ : new MergeFourthMomentNumeric()).put("$FOURTHMOMENT",
Review Comment:
nit please revert non-relevant changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]