walterddr commented on code in PR #10413:
URL: https://github.com/apache/pinot/pull/10413#discussion_r1136501976
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -68,24 +69,22 @@ interface MailboxIdGenerator {
MailboxIdentifier generate(VirtualServer server);
}
- public MailboxSendOperator(MailboxService<TransferableBlock> mailboxService,
- MultiStageOperator dataTableBlockBaseOperator, List<VirtualServer>
receivingStageInstances,
- RelDistribution.Type exchangeType, KeySelector<Object[], Object[]>
keySelector,
- VirtualServerAddress sendingServer, long jobId, int senderStageId, int
receiverStageId, long deadlineMs) {
- this(mailboxService, dataTableBlockBaseOperator, receivingStageInstances,
exchangeType, keySelector,
- server -> toMailboxId(server, jobId, senderStageId, receiverStageId,
sendingServer), BlockExchange::getExchange,
- jobId, senderStageId, receiverStageId, sendingServer, deadlineMs);
+ public MailboxSendOperator(MultiStageOperator dataTableBlockBaseOperator,
RelDistribution.Type exchangeType,
Review Comment:
nit same here. please not enable auto-reformat so that the PR can be
cleaner. thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
