abhioncbr commented on PR #10446: URL: https://github.com/apache/pinot/pull/10446#issuecomment-1479884085
> > @swaminathanmanish can you please review the changes? > > Thanks for taking this up. Actually we already have a nice swagger API that dumps all configs which is convenient to use. We don't need to look at the logs :). Do we really need these logs? > > curl -X GET "http://localhost:9000/appconfigs"; -H "accept: application/json" > > jvmConfig": { "args": [ "-javaagent:/Applications/IntelliJ IDEA CE.app/Contents/lib/idea_rt.jar=50367:/Applications/IntelliJ IDEA CE.app/Contents/bin", "-Dfile.encoding=UTF-8" ], "garbageCollectors": [ "G1 Young Generation", "G1 Old Generation" ], "envVariables": { "__CFBundleIdentifier": "com.jetbrains.intellij.ce", "PATH": "/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin", "SHELL": "/bin/zsh", "MANPATH": "/opt/homebrew/share/man::", "HOMEBREW_CELLAR": "/opt/homebrew/Cellar", "OLDPWD": "/", "USER": "manishswaminathan", "HOMEBREW_PREFIX": "/opt/homebrew", "COMMAND_MODE": "unix2003", "TMPDIR": "/var/folders/xj/yl13brv573g9_v_vhxx7knx00000gn/T/", "SSH_AUTH_SOCK": "/private/tmp/com.apple.launchd.lyuZIHVl7g/Listeners", "XPC_FLAGS": "0x0", "__CF_USER_TEXT_ENCODING": "0x1F5:0x0:0x0", "LOGNAME": "manishswaminathan", "LC_CTYPE": "en_US.UTF-8", "HOMEBREW_REPOSITORY": "/opt/homebrew", "JAVA_MAIN_CLASS_1666": "org.apache.pinot .tools.Quickstart", "PWD": "/Users/manishswaminathan/projects/forked/pinot", "XPC_SERVICE_NAME": "application.com.jetbrains.intellij.ce.975373.976077", "INFOPATH": "/opt/homebrew/share/info:", "HOME": "/Users/manishswaminathan" }, I think, there is no harm in adding up the logs if it makes someone's life easy. Rest, I have no such strong preferences to add to logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
