Jackie-Jiang commented on code in PR #10446:
URL: https://github.com/apache/pinot/pull/10446#discussion_r1149798237
##########
pinot-tools/src/main/java/org/apache/pinot/tools/service/PinotServiceManager.java:
##########
@@ -107,6 +108,7 @@ public String startRole(ServiceRole role, Map<String,
Object> properties)
public String startController(String controllerStarterClassName,
PinotConfiguration controllerConf)
throws Exception {
LOGGER.info("Trying to start Pinot Controller...");
+ LOGGER.info(new PinotAppConfigs(controllerConf).getJvmInputArguments());
Review Comment:
I don't think we need to log here because it will be logged within the
component starter
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -223,6 +224,7 @@ public PinotConfiguration getConfig() {
public void start()
throws Exception {
LOGGER.info("Starting Pinot broker (Version: {})", PinotVersion.VERSION);
+ LOGGER.info(new PinotAppConfigs(getConfig()).getJvmInputArguments());
Review Comment:
We can probably log everything within the `PinotAppConfigs` by calling:
```suggestion
LOGGER.info("Broker configs: {}", new
PinotAppConfigs(getConfig()).toJSONString());
```
Same for other components
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
