jackjlli commented on code in PR #10507:
URL: https://github.com/apache/pinot/pull/10507#discussion_r1152493597
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java:
##########
@@ -1130,6 +1130,22 @@ public int downloadFile(URI uri, File dest)
return downloadFile(uri, dest, null);
}
+ /**
+ * Download a file with a configurable timeout
+ *
+ * @param uri URI
+ * @param dest File destination
+ * @param authProvider auth provider
+ * @param socketTimeoutMs connection socket timeout ms
+ * @return Response status code
+ * @throws IOException
+ * @throws HttpErrorStatusException
+ */
+ public int downloadFile(URI uri, File dest, AuthProvider authProvider, int
socketTimeoutMs)
Review Comment:
nit: could you change the Line 1161 to invoke this method in order to avoid
duplicate logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
