Jackie-Jiang commented on code in PR #10507:
URL: https://github.com/apache/pinot/pull/10507#discussion_r1153629910
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java:
##########
@@ -1149,16 +1165,17 @@ public int downloadFile(URI uri, File dest,
AuthProvider authProvider)
* Download a file.
*
* @param uri URI
+ * @param socketTimeoutMs socketTimeoutMs
* @param dest File destination
* @param authProvider auth provider
* @param httpHeaders http headers
* @return Response status code
* @throws IOException
* @throws HttpErrorStatusException
*/
- public int downloadFile(URI uri, File dest, AuthProvider authProvider,
List<Header> httpHeaders)
+ public int downloadFile(URI uri, int socketTimeoutMs, File dest,
AuthProvider authProvider, List<Header> httpHeaders)
Review Comment:
Let's keep this signature as is, and add a new one which takes
`socketTimeoutMs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
