gortiz commented on code in PR #10184:
URL: https://github.com/apache/pinot/pull/10184#discussion_r1153295434
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -920,10 +929,10 @@ private void
disableDictionaryAndCreateRawForwardIndex(String column, SegmentDir
}
private void rewriteDictToRawForwardIndex(String column, ColumnMetadata
existingColMetadata,
- SegmentDirectory.Writer segmentWriter, File indexDir,
IndexCreatorProvider indexCreatorProvider)
+ SegmentDirectory.Writer segmentWriter, File indexDir)
throws Exception {
- try (ForwardIndexReader reader =
LoaderUtils.getForwardIndexReader(segmentWriter, existingColMetadata)) {
- Dictionary dictionary = LoaderUtils.getDictionary(segmentWriter,
existingColMetadata);
+ try (ForwardIndexReader<?> reader =
ForwardIndexType.getReader(segmentWriter, existingColMetadata)) {
+ Dictionary dictionary = DictionaryIndexType.read(segmentWriter,
existingColMetadata);
Review Comment:
I don't think we can do that. I've tried to explain why
[here](https://github.com/apache/pinot/pull/10184#discussion_r1153291384).
Let's focus the discussion there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
