gortiz commented on code in PR #10184:
URL: https://github.com/apache/pinot/pull/10184#discussion_r1153297400
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -444,26 +526,31 @@ public void setColumnProperties(Map<String, Map<String,
String>> columnPropertie
@VisibleForTesting
public void setInvertedIndexColumns(Set<String> invertedIndexColumns) {
_invertedIndexColumns = new HashSet<>(invertedIndexColumns);
+ _dirty = true;
}
@VisibleForTesting
public void addInvertedIndexColumns(String... invertedIndexColumns) {
_invertedIndexColumns.addAll(Arrays.asList(invertedIndexColumns));
+ _dirty = true;
}
@VisibleForTesting
public void addInvertedIndexColumns(Collection<String> invertedIndexColumns)
{
_invertedIndexColumns.addAll(invertedIndexColumns);
+ _dirty = true;
}
@VisibleForTesting
public void removeInvertedIndexColumns(String... invertedIndexColumns) {
removeInvertedIndexColumns(Arrays.asList(invertedIndexColumns));
+ assert _dirty;
Review Comment:
That is how an assert should always be used, right? To remark some invariant
we know that is true when we write the assert, but may not be true some time
later when someone touches `removeInvertedIndexColumns(List)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
