ankitsultana commented on code in PR #10423:
URL: https://github.com/apache/pinot/pull/10423#discussion_r1156750383


##########
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTestBase.java:
##########
@@ -130,9 +140,15 @@ protected Object[][] provideQueries() {
 
   public static QueryEnvironment getQueryEnvironment(int reducerPort, int 
port1, int port2,
       Map<String, Schema> schemaMap, Map<String, List<String>> segmentMap1, 
Map<String, List<String>> segmentMap2) {
+    return getQueryEnvironment(reducerPort, port1, port2, schemaMap, 
segmentMap1, segmentMap2, Collections.emptyMap());

Review Comment:
   ^ Let's add a table or two which have `nullHandlingEnabled: true` in 
table-config. Anti semi join queries (NOT IN) kind of queries would turn into 
broadcast joins in that case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to