walterddr commented on code in PR #10423:
URL: https://github.com/apache/pinot/pull/10423#discussion_r1152506937
##########
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTestBase.java:
##########
@@ -130,9 +131,16 @@ protected Object[][] provideQueries() {
public static QueryEnvironment getQueryEnvironment(int reducerPort, int
port1, int port2,
Map<String, Schema> schemaMap, Map<String, List<String>> segmentMap1,
Map<String, List<String>> segmentMap2) {
+ return getQueryEnvironment(reducerPort, port1, port2, schemaMap,
segmentMap1, segmentMap2, Collections.emptyMap());
+ }
+
+ public static QueryEnvironment getQueryEnvironment(int reducerPort, int
port1, int port2,
+ Map<String, Schema> schemaMap, Map<String, List<String>> segmentMap1,
Map<String, List<String>> segmentMap2,
+ Map<String, Boolean> nullHandlingMap) {
MockRoutingManagerFactory factory = new MockRoutingManagerFactory(port1,
port2);
for (Map.Entry<String, Schema> entry : schemaMap.entrySet()) {
- factory.registerTable(entry.getValue(), entry.getKey());
+ // ALWAYS enable null handling in V2.
+ factory.registerTable(entry.getValue(), entry.getKey(),
nullHandlingMap.getOrDefault(entry.getKey(), false));
Review Comment:
ah i think the comment was not suppose to be there. what i meant was
"nullhandling query option" was enabled always, not "null column is always
registered for table" :-P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
