swaminathanmanish opened a new pull request, #10557: URL: https://github.com/apache/pinot/pull/10557
**Problem**: [The decision to override dictionary config](https://github.com/apache/pinot/pull/8398) in the segment generation path (indexConfig options -> optimizeDictionaryForMetrics, optimizeDictionary) gets [reverted in the segment reload path](https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java#L305). This was not handled in the reload path (a regression?). These override options (optimizeDictionaryForMetrics, optimizeDictionary) were added as a safeguard to prevent issues when dictionary can cause more harm than good. **Solution:** Factored out common logic that'll be shared between segment generation and reload path. This ensures that segment generation and reload use the same logic to take the decision to override. **Tests**: 1) Added unit tests for core logic that makes the override decision 2) Quickstart run to verify that dictionary -> noDictionary happens after segment reload -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
