somandal commented on code in PR #10557:
URL: https://github.com/apache/pinot/pull/10557#discussion_r1160230353
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -309,8 +309,16 @@ Map<String, List<Operation>>
computeOperations(SegmentDirectory.Reader segmentRe
LOGGER.warn("Cannot enable dictionary for column={} as schema or
tableConfig is null.", column);
continue;
}
-
- columnOperationsMap.put(column,
Collections.singletonList(Operation.ENABLE_DICTIONARY));
+ ColumnMetadata existingColumnMetadata =
_segmentDirectory.getSegmentMetadata().getColumnMetadataFor(column);
Review Comment:
Sounds good, can you add the validations to ensure optimizer configs aren't
enabled for a forwardIndexDisabled column in
`TableConfigUtils::validateForwardIndexDisabledIndexCompatibility()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
