siddharthteotia commented on code in PR #10565:
URL: https://github.com/apache/pinot/pull/10565#discussion_r1162460063
##########
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/QueryContextConverterUtils.java:
##########
@@ -155,11 +157,91 @@ public static QueryContext getQueryContext(PinotQuery
pinotQuery) {
}
}
- return new
QueryContext.Builder().setTableName(tableName).setSubquery(subquery)
-
.setSelectExpressions(selectExpressions).setAliasList(aliasList).setFilter(filter)
-
.setGroupByExpressions(groupByExpressions).setOrderByExpressions(orderByExpressions)
-
.setHavingFilter(havingFilter).setLimit(pinotQuery.getLimit()).setOffset(pinotQuery.getOffset())
-
.setQueryOptions(pinotQuery.getQueryOptions()).setExpressionOverrideHints(expressionContextOverrideHints)
- .setExplain(pinotQuery.isExplain()).build();
+ return new
QueryContext.Builder().setDataSource(dataSource).setSelectExpressions(selectExpressions)
+
.setAliasList(aliasList).setFilter(filter).setGroupByExpressions(groupByExpressions)
+
.setOrderByExpressions(orderByExpressions).setHavingFilter(havingFilter).setLimit(pinotQuery.getLimit())
+
.setOffset(pinotQuery.getOffset()).setQueryOptions(pinotQuery.getQueryOptions())
+
.setExpressionOverrideHints(expressionContextOverrideHints).setExplain(pinotQuery.isExplain()).build();
+ }
+
+ private static DataSourceContext getDataSourceContext(DataSource dataSource)
{
+ String tableName = dataSource.getTableName();
+ QueryContext subquery = null;
+ if (dataSource.getSubquery() != null) {
Review Comment:
qq - this will be null right if `getJoin()` returns non-null ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
