siddharthteotia commented on code in PR #10565: URL: https://github.com/apache/pinot/pull/10565#discussion_r1162817468
########## pinot-core/src/main/java/org/apache/pinot/core/query/request/context/JoinContext.java: ########## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.request.context; + +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.spi.utils.builder.TableNameBuilder; + + +public class JoinContext { + private final String _leftTableName; + private final String _rawLeftTableName; + private final String _rightTableName; + private final ExpressionContext _leftJoinKey; + private final String _rightJoinKey; + + public JoinContext(String leftTableName, String rightTableName, ExpressionContext leftJoinKey, String rightJoinKey) { + _leftTableName = leftTableName; + _rawLeftTableName = TableNameBuilder.extractRawTableName(leftTableName); + _rightTableName = rightTableName; + _leftJoinKey = leftJoinKey; + _rightJoinKey = rightJoinKey; + } + + public String getLeftTableName() { + return _leftTableName; + } + + public String getRawLeftTableName() { + return _rawLeftTableName; + } + + public String getRightTableName() { + return _rightTableName; + } + + public ExpressionContext getLeftJoinKey() { + return _leftJoinKey; + } + + public String getRightJoinKey() { Review Comment: (nit) this can also be modeled as `ExpressionContext` and we can enforce (for now) that this always be an `IDENTIFIER` type of expression. Upto you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
