walterddr commented on code in PR #10574:
URL: https://github.com/apache/pinot/pull/10574#discussion_r1169448970
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseStats.java:
##########
@@ -49,7 +50,7 @@ public class BrokerResponseStats extends BrokerResponseNative
{
private long _stageExecutionTimeMs = 0;
private int _stageExecutionUnit = 0;
private long _stageExecWallTimeMs = -1;
- private Map<String, Map<String, String>> _operatorStats = new HashMap<>();
+ private Map<OperatorId, Map<String, String>> _operatorStats = new
HashMap<>();
Review Comment:
I dont really think it is necessary to change the String type to OperatorId
type -->
what we really need is to ensure that the same `requestId + stageId +
operatorId` --> operatorId is monotonic increasing from the bottom receive
operator to the top send operator. the actual JSON doesn't need to be sorted
--> we can always post process or do the sorting when rendering the JSON
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
