KKcorps commented on code in PR #10574:
URL: https://github.com/apache/pinot/pull/10574#discussion_r1169672468
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java:
##########
@@ -32,14 +32,14 @@
public abstract class MultiStageOperator implements
Operator<TransferableBlock>, AutoCloseable {
private static final org.slf4j.Logger LOGGER =
LoggerFactory.getLogger(MultiStageOperator.class);
- private final String _operatorId;
- private final OpChainExecutionContext _context;
+ private final OperatorId _operatorId;
+ protected final OpChainExecutionContext _context;
protected final OpChainStats _opChainStats;
public MultiStageOperator(OpChainExecutionContext context) {
_context = context;
- _operatorId =
- Joiner.on("_").join(toExplainString(), _context.getRequestId(),
_context.getStageId(), _context.getServer());
+ _operatorId = new OperatorId(_context.getRequestId(),
_context.getStageId(), _context.getServer().toString(),
+ toExplainString(), null);
Review Comment:
Yeah, so issue is the opChainContext is created during the visitor. And
before visiting all nodes, we can't really index them correctly based on the
position in the chain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
