siddharthteotia commented on code in PR #10649:
URL: https://github.com/apache/pinot/pull/10649#discussion_r1171874154
##########
pinot-core/src/test/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactoryTest.java:
##########
@@ -255,25 +255,37 @@ public void testGetAggregationFunction() {
aggregationFunction =
AggregationFunctionFactory.getAggregationFunction(function,
DUMMY_QUERY_CONTEXT);
assertTrue(aggregationFunction instanceof
PercentileTDigestAggregationFunction);
assertEquals(aggregationFunction.getType(),
AggregationFunctionType.PERCENTILETDIGEST);
- assertEquals(aggregationFunction.getResultColumnName(),
"percentiletdigest(column, 99.0)");
+ assertEquals(aggregationFunction.getResultColumnName(),
"percentiletdigest(column, 99.0, 100.0)");
function = getFunction("PeRcEnTiLeTdIgEsT", "(column, 99.9999)");
aggregationFunction =
AggregationFunctionFactory.getAggregationFunction(function,
DUMMY_QUERY_CONTEXT);
assertTrue(aggregationFunction instanceof
PercentileTDigestAggregationFunction);
assertEquals(aggregationFunction.getType(),
AggregationFunctionType.PERCENTILETDIGEST);
- assertEquals(aggregationFunction.getResultColumnName(),
"percentiletdigest(column, 99.9999)");
+ assertEquals(aggregationFunction.getResultColumnName(),
"percentiletdigest(column, 99.9999, 100.0)");
+
+ function = getFunction("PeRcEnTiLeTdIgEsT", "(column, 99.9999, 1000)");
+ aggregationFunction =
AggregationFunctionFactory.getAggregationFunction(function,
DUMMY_QUERY_CONTEXT);
+ assertTrue(aggregationFunction instanceof
PercentileTDigestAggregationFunction);
+ assertEquals(aggregationFunction.getType(),
AggregationFunctionType.PERCENTILETDIGEST);
+ assertEquals(aggregationFunction.getResultColumnName(),
"percentiletdigest(column, 99.9999, 1000.0)");
function = getFunction("PeRcEnTiLeRaWtDiGeSt", "(column, 99)");
aggregationFunction =
AggregationFunctionFactory.getAggregationFunction(function,
DUMMY_QUERY_CONTEXT);
assertTrue(aggregationFunction instanceof
PercentileRawTDigestAggregationFunction);
assertEquals(aggregationFunction.getType(),
AggregationFunctionType.PERCENTILERAWTDIGEST);
- assertEquals(aggregationFunction.getResultColumnName(),
"percentilerawtdigest(column, 99.0)");
+ assertEquals(aggregationFunction.getResultColumnName(),
"percentilerawtdigest(column, 99.0, 100.0)");
Review Comment:
cc @somandal @jasperjiaguo
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileRawTDigestAggregationFunction.java:
##########
@@ -59,11 +64,12 @@ public AggregationFunctionType getType() {
@Override
public String getResultColumnName() {
final double percentile =
_percentileTDigestAggregationFunction._percentile;
+ final double compressionFactor =
_percentileTDigestAggregationFunction._compressionFactor;
final int version = _percentileTDigestAggregationFunction._version;
final String type = getType().getName().toLowerCase();
return version == 0 ? type + (int) percentile + "(" + _expression + ")"
- : type + "(" + _expression + ", " + percentile + ")";
+ : type + "(" + _expression + ", " + percentile + ", " +
compressionFactor + ")";
Review Comment:
+1 I just gave a similar comment too. Result column name should not change
imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
