somandal commented on code in PR #10649:
URL: https://github.com/apache/pinot/pull/10649#discussion_r1171902868
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileTDigestAggregationFunction.java:
##########
@@ -38,21 +38,32 @@
public class PercentileTDigestAggregationFunction extends
BaseSingleInputAggregationFunction<TDigest, Double> {
Review Comment:
will do once this change makes it in :)
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileRawTDigestAggregationFunction.java:
##########
@@ -59,11 +64,12 @@ public AggregationFunctionType getType() {
@Override
public String getResultColumnName() {
final double percentile =
_percentileTDigestAggregationFunction._percentile;
+ final double compressionFactor =
_percentileTDigestAggregationFunction._compressionFactor;
final int version = _percentileTDigestAggregationFunction._version;
final String type = getType().getName().toLowerCase();
return version == 0 ? type + (int) percentile + "(" + _expression + ")"
- : type + "(" + _expression + ", " + percentile + ")";
+ : type + "(" + _expression + ", " + percentile + ", " +
compressionFactor + ")";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
