KKcorps commented on code in PR #10613:
URL: https://github.com/apache/pinot/pull/10613#discussion_r1181444730
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/GreatestTransformFunction.java:
##########
@@ -74,6 +135,35 @@ public float[] transformToFloatValuesSV(ValueBlock
valueBlock) {
return _floatValuesSV;
}
+ @Override
+ public Pair<float[], RoaringBitmap>
transformToFloatValuesSVWithNull(ValueBlock valueBlock) {
+ int numDocs = valueBlock.getNumDocs();
+ initFloatValuesSV(numDocs);
+ Pair<float[], RoaringBitmap> values =
_arguments.get(0).transformToFloatValuesSVWithNull(valueBlock);
+ System.arraycopy(values.getLeft(), 0, _floatValuesSV, 0, numDocs);
+ RoaringBitmap nullBitmap = values.getRight();
+ for (int i = 1; i < _arguments.size(); i++) {
Review Comment:
Can we extract out this logic in a method. Seems like the only difference is
the datatype of the array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
